projects / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: bde23c6) | patch
PTR_ERR should be called before its argument is cleared.
authorJulia Lawall <Julia.Lawall@lip6.fr>
Thu, 2 Feb 2012 15:52:54 +0000 (07:52 -0800)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Tue, 21 Feb 2012 17:06:10 +0000 (09:06 -0800)
commit3c1b1ce00d2702d6be9b92233822e560f37ea780
tree302e888faea366f7caccd6ad946bdde6d8e9137etree | snapshot
parentbde23c6892878e48f64de668660778991bc2fb56commit | diff
PTR_ERR should be called before its argument is cleared.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e,e1;
constant c;
@@

*e = c
... when != e = e1
    when != &e
    when != true IS_ERR(e)
*PTR_ERR(e)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reported-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
kernel/rcutorture.c diff | blob | history
ep93xx device tree rework repo: git://git.maquefel.me/linux.git