Bluetooth: cmtp: fix file refcount when cmtp_attach_device fails
authorThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Tue, 13 Apr 2021 16:21:03 +0000 (13:21 -0300)
committerMarcel Holtmann <marcel@holtmann.org>
Sat, 26 Jun 2021 05:12:25 +0000 (07:12 +0200)
commit3cfdf8fcaafa62a4123f92eb0f4a72650da3a479
tree13b754f68b1f05811bdc90ac841064c849d94104
parent44e936d7459cac598d9fe0b6d23cc9d12b648d5e
Bluetooth: cmtp: fix file refcount when cmtp_attach_device fails

When cmtp_attach_device fails, cmtp_add_connection returns the error value
which leads to the caller to doing fput through sockfd_put. But
cmtp_session kthread, which is stopped in this path will also call fput,
leading to a potential refcount underflow or a use-after-free.

Add a refcount before we signal the kthread to stop. The kthread will try
to grab the cmtp_session_sem mutex before doing the fput, which is held
when get_file is called, so there should be no races there.

Reported-by: Ryota Shiga
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/cmtp/core.c