scsi: ibmvscsi: Avoid multi-field memset() overflow by aiming at srp
authorKees Cook <keescook@chromium.org>
Mon, 21 Jun 2021 19:07:10 +0000 (12:07 -0700)
committerKees Cook <keescook@chromium.org>
Sat, 25 Sep 2021 15:20:47 +0000 (08:20 -0700)
commit3d0107a7fee40402f0a3a325604bcbbc47597b5a
treea9cec765a2459179657096962ae6cedeb88aca5f
parente4e737bb5c170df6135a127739a9e6148ee3da82
scsi: ibmvscsi: Avoid multi-field memset() overflow by aiming at srp

In preparation for FORTIFY_SOURCE performing compile-time and run-time
field bounds checking for memset(), avoid intentionally writing across
neighboring fields.

Instead of writing beyond the end of evt_struct->iu.srp.cmd, target the
upper union (evt_struct->iu.srp) instead, as that's what is being wiped.

Cc: Tyrel Datwyler <tyreld@linux.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/lkml/yq135rzp79c.fsf@ca-mkp.ca.oracle.com
Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>
Link: https://lore.kernel.org/lkml/6eae8434-e9a7-aa74-628b-b515b3695359@linux.ibm.com
drivers/scsi/ibmvscsi/ibmvscsi.c