drm/i915/clflush: fixup handling of cache_dirty
authorMatthew Auld <matthew.auld@intel.com>
Wed, 27 Oct 2021 16:18:10 +0000 (17:18 +0100)
committerMatthew Auld <matthew.auld@intel.com>
Tue, 2 Nov 2021 09:43:10 +0000 (09:43 +0000)
commit3ea355b234d7d3e543b89e55c66d57db50ef1581
tree44b99c866e0ca63b9cb2320b66573ecfce0704fd
parentcad7109a2b5e7d48466b77728aa16ce55415eea0
drm/i915/clflush: fixup handling of cache_dirty

In theory if clflush_work_create() somehow fails here, and we don't yet
have mm.pages populated then we end up resetting cache_dirty, which is
likely wrong, since that will potentially skip the flush-on-acquire, if
it was needed.

It looks like intel_user_framebuffer_dirty() can arrive here before the
pages are populated.

v2(Thomas):
  - Move setting cache_dirty out of the async portion, also add a
    comment for why that should still be safe.
v3:
  - Add Thomas' irc r-b

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211027161813.3094681-1-matthew.auld@intel.com
drivers/gpu/drm/i915/gem/i915_gem_clflush.c