osdep: Work around MinGW assert
authorRichard Henderson <richard.henderson@linaro.org>
Mon, 22 Oct 2018 18:16:23 +0000 (19:16 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 23 Oct 2018 09:12:46 +0000 (10:12 +0100)
commit3ebee3b191e755d3f7311a6a62eea5c9628b221b
tree2bd1549ce5e0a97ad8300b867cf786d3c1299357
parent99e2487e00c4fbdd2deeeeeac88bb5d6d4e0dc1d
osdep: Work around MinGW assert

In several places we use assert(FEATURE), and assume that if FEATURE
is disabled, all following code is removed as unreachable.  Which allows
us to compile-out functions that are only present with FEATURE, and
have a link-time failure if the functions remain used.

MinGW does not mark its internal function _assert() as noreturn, so the
compiler cannot see when code is unreachable, which leads to link errors
for this host that are not present elsewhere.

The current build-time failure concerns 62823083b8a2, but I remember
having seen this same error before.  Fix it once and for all for MinGW.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20181022181623.8810-1-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
include/qemu/osdep.h