drm/mediatek: Fix iommu fault by swapping FBs after updating plane state
authorJason-JH.Lin <jason-jh.lin@mediatek.com>
Wed, 9 Aug 2023 12:57:21 +0000 (20:57 +0800)
committerChun-Kuang Hu <chunkuang.hu@kernel.org>
Sun, 8 Oct 2023 01:28:31 +0000 (01:28 +0000)
commit3ec71e05ae6e7f46512e568ed81c92be589003dd
tree40038fef0649b6fe8637d571017e9e2d829db7c5
parent26fdd23ff861d5436f70f67a09161b06d2c306e2
drm/mediatek: Fix iommu fault by swapping FBs after updating plane state

According to the comment in drm_atomic_helper_async_commit(),
we should make sure FBs have been swapped, so that cleanups in the
new_state performs a cleanup in the old FB.

So we should move swapping FBs after calling mtk_plane_update_new_state(),
to avoid using the old FB which could be freed.

Fixes: 1a64a7aff8da ("drm/mediatek: Fix cursor plane no update")
Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Link: https://patchwork.kernel.org/project/linux-mediatek/patch/20230809125722.24112-2-jason-jh.lin@mediatek.com/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
drivers/gpu/drm/mediatek/mtk_drm_plane.c