mtd: maps: sa1100-flash: Prefer struct_size over open coded arithmetic
authorErick Archer <erick.archer@outlook.com>
Sat, 30 Mar 2024 17:55:35 +0000 (18:55 +0100)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 9 Apr 2024 06:35:37 +0000 (08:35 +0200)
commit3ef4600f12269d489933b3835fe8d43621e4ee6c
tree0684ea356ea4d7c7e8c56309e9ebce10bfd20524
parent5043e5553601504995300c98141230f5edd11933
mtd: maps: sa1100-flash: Prefer struct_size over open coded arithmetic

This is an effort to get rid of all multiplications from allocation
functions in order to prevent integer overflows [1][2].

As the "info" variable is a pointer to "struct sa_info" and this
structure ends in a flexible array:

struct sa_info {
[...]
struct sa_subdev_info subdev[];
};

the preferred way in the kernel is to use the struct_size() helper to
do the arithmetic instead of the calculation "size + size * count" in
the kzalloc() function.

This way, the code is more readable and safer.

This code was detected with the help of Coccinelle, and audited and
modified manually.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
Link: https://github.com/KSPP/linux/issues/160
Signed-off-by: Erick Archer <erick.archer@outlook.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/AS8PR02MB7237AC633B0D1D2EBD3C40E98B392@AS8PR02MB7237.eurprd02.prod.outlook.com
drivers/mtd/maps/sa1100-flash.c