media: atomisp: Simplify atomisp_[start|stop]_streaming()
authorHans de Goede <hdegoede@redhat.com>
Thu, 11 May 2023 15:03:38 +0000 (16:03 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 9 Jun 2023 13:37:12 +0000 (14:37 +0100)
commit3f3ee94c89b79c9addaf83b029edec9b720ec1f7
treef519b7d5cdd56ae209cf0b368035179a6e083668
parent1ae393ea3dbc0a75f1eb460d32d56a4f18dfd684
media: atomisp: Simplify atomisp_[start|stop]_streaming()

Now that continuous mode is gone and we only have 1 /dev/video# node,
the videobuf2 core guarantees that atomisp_[start|stop]_streaming() will
only be called one at a time.

So there is no need to check for things like the isp is already streaming
when starting, or other streams still being active while stopping.
Remove checks for these from atomisp_[start|stop]_streaming().

While at it also improve the logging a bit:
1. Remove the dev_err(isp->dev, "atomisp_reset") logged on every
   stream stop (even though everything is fine.
2. Log a message when starting/stopping the sensor stream fails

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_ioctl.c