HID: hid-thrustmaster: fix OOB read in thrustmaster_interrupts
authorPavel Skripkin <paskripkin@gmail.com>
Sun, 20 Feb 2022 16:01:14 +0000 (19:01 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Mar 2022 13:23:35 +0000 (14:23 +0100)
commit3ffbe85cda7f523dad896bae08cecd8db8b555ab
tree4819fedbd2a0607dbf7a00c7390b6e8601bdab05
parenta5334502f91fe68b7edee502af20b292ad42259a
HID: hid-thrustmaster: fix OOB read in thrustmaster_interrupts

[ Upstream commit fc3ef2e3297b3c0e2006b5d7b3d66965e3392036 ]

Syzbot reported an slab-out-of-bounds Read in thrustmaster_probe() bug.
The root case is in missing validation check of actual number of endpoints.

Code should not blindly access usb_host_interface::endpoint array, since
it may contain less endpoints than code expects.

Fix it by adding missing validaion check and print an error if
number of endpoints do not match expected number

Fixes: c49c33637802 ("HID: support for initialization of some Thrustmaster wheels")
Reported-and-tested-by: syzbot+35eebd505e97d315d01c@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-thrustmaster.c