vfio/pds: Fix calculations in pds_vfio_dirty_sync
authorBrett Creeley <brett.creeley@amd.com>
Fri, 17 Nov 2023 00:12:02 +0000 (16:12 -0800)
committerAlex Williamson <alex.williamson@redhat.com>
Mon, 4 Dec 2023 21:33:20 +0000 (14:33 -0700)
commit4004497cec3093d7b0087bc70709b45969fa07b6
tree6c8cb5cdba01104dfb41a382cd9b85d05baea2dd
parent33cc938e65a98f1d29d0a18403dbbee050dcad9a
vfio/pds: Fix calculations in pds_vfio_dirty_sync

The incorrect check is being done for comparing the
iova/length being requested to sync. This can cause
the dirty sync operation to fail. Fix this by making
sure the iova offset added to the requested sync
length doesn't exceed the region_size.

Also, the region_start is assumed to always be at 0.
This can cause dirty tracking to fail because the
device/driver bitmap offset always starts at 0,
however, the region_start/iova may not. Fix this by
determining the iova offset from region_start to
determine the bitmap offset.

Fixes: f232836a9152 ("vfio/pds: Add support for dirty page tracking")
Signed-off-by: Brett Creeley <brett.creeley@amd.com>
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Link: https://lore.kernel.org/r/20231117001207.2793-2-brett.creeley@amd.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/pci/pds/dirty.c