scripts/gdb: fix detection of current CPU in KGDB
authorFlorian Rommel <mail@florommel.de>
Thu, 25 Apr 2024 15:35:01 +0000 (17:35 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 8 May 2024 15:41:28 +0000 (08:41 -0700)
commit40eea5abbb9ccae6df55dfd94c3c85c023e2521b
tree19ca37ca7816fd808fafd27d3fcd2443ccc7ad3a
parent7566b063e9e4af908123ebe8b80cc0d0c7429507
scripts/gdb: fix detection of current CPU in KGDB

Directly read the current CPU number from the kgdb_active variable.

Before, the active CPU was obtained through the current task, which
required searching the task list for the pid of GDB's selected thread.
Obtaining the pid was buggy: GDB may use selected_thread().ptid[1] (LWPID)
instead of .ptid[2] (TID) to store the threads pid; see
https://sourceware.org/gdb/current/onlinedocs/gdb.html/Threads-In-Python.html
As a result, the detection could return the wrong CPU number, leading to
incorrect results for $lx_per_cpu and $lx_current.

As a side effect, the patch significantly speeds up $lx_per_cpu and
$lx_current in KGDB by avoiding the task-list iteration.

Link: https://lkml.kernel.org/r/20240425153501.749966-5-mail@florommel.de
Signed-off-by: Florian Rommel <mail@florommel.de>
Cc: Andrew Jones <ajones@ventanamicro.com>
Cc: Deepak Gupta <debug@rivosinc.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Kieran Bingham <kbingham@kernel.org>
Cc: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Cc: Palmer Dabbelt <palmer@rivosinc.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
scripts/gdb/linux/cpus.py