wifi: ath12k: change to initialize recovery variables earlier in ath12k_core_reset()
authorWen Gong <quic_wgong@quicinc.com>
Wed, 30 Aug 2023 06:08:50 +0000 (02:08 -0400)
committerKalle Valo <quic_kvalo@quicinc.com>
Wed, 20 Sep 2023 13:37:30 +0000 (16:37 +0300)
commit41e7a399aea1dbf3d0ffdeb6ef8e9eaea7fa6cf5
treea85eb485a097992238545797afd2441eb829896d
parentd4e244c85e45df8e044a1f097e1c78bafd6ec21f
wifi: ath12k: change to initialize recovery variables earlier in ath12k_core_reset()

Sometimes device recovery fail with this operation.
Run test command for many times:
echo assert > /sys/kernel/debug/ath12k/wcn7850\ hw2.0_0000\:03\:00.0/simulate_fw_crash

While recovery start, ath12k_core_post_reconfigure_recovery() will
call ieee80211_restart_hw(), and the restart_work which queued by
ieee80211_restart_hw() is running in another thread, it will call
into ath12k_mac_op_start() and ath12k_mac_wait_reconfigure(), and
the variables ab->recovery_start_count and ab->recovery_start is used
in ath12k_mac_wait_reconfigure(), so ath12k need to initialize the
variables before queue the restart_work, otherwise ath12k_mac_wait_reconfigure()
maybe use the un-initialized variables. Change to initialize the 2
variables earlier and then recovery process become correct.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4

Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230830060850.18881-1-quic_wgong@quicinc.com
drivers/net/wireless/ath/ath12k/core.c