clk: at91: remove unnecessary conditions
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 17 Oct 2023 14:06:53 +0000 (17:06 +0300)
committerStephen Boyd <sboyd@kernel.org>
Thu, 19 Oct 2023 00:56:13 +0000 (17:56 -0700)
commit43a354a21a6a21f050b95317148661a465108cba
tree93bd2ef557636e34a108ef509676b398f7901388
parent7af5b9eadd64c9e02a71f97c45bcdf3b64841f6b
clk: at91: remove unnecessary conditions

This code checks "if (parent_hw)" is non-NULL, but then it has more
checks if parent_hw is non-NULL on the lines inside the if statement.
It is a bit confusing.

For the else statement, keep in mind that at the start of the function
we checked:

if (!(parent_name || parent_hw))
return ERR_PTR(-EINVAL);

That check ensures that if parent_hw is NULL that means that parent_name
is non-NULL.  At least one must always be non-NULL.  So here again, the
checks inside the if statement can be removed.

In the original code, it was a bit confusing and you could easily get
the impression that "init.num_parents" could be zero.  When we remove
the unnecessary checking it's more obvious that it's always set to 1.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/7782b4f1-deed-49dc-8207-b6ea06d7602f@moroto.mountain
Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/at91/clk-utmi.c