bonding: 802.3ad replace MAC_ADDRESS_EQUAL with __agg_has_partner
authorJones Syue 薛懷宗 <jonessyue@qnap.com>
Mon, 26 Feb 2024 02:24:52 +0000 (02:24 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 28 Feb 2024 02:18:31 +0000 (18:18 -0800)
commit4440873f3655325f849366d75382aa05d09b5575
tree3b0ecd28d05295c3b653a2e55be10e43fa3b619c
parent848e34ca203046c9b967034596828472f08e4ac7
bonding: 802.3ad replace MAC_ADDRESS_EQUAL with __agg_has_partner

Replace macro MAC_ADDRESS_EQUAL() for null_mac_addr checking with inline
function__agg_has_partner(). When MAC_ADDRESS_EQUAL() is verifiying
aggregator's partner mac addr with null_mac_addr, means that seeing if
aggregator has a valid partner or not. Using __agg_has_partner() makes it
more clear to understand.

In ad_port_selection_logic(), since aggregator->partner_system and
port->partner_oper.system has been compared first as a prerequisite, it is
safe to replace the upcoming MAC_ADDRESS_EQUAL() for null_mac_addr checking
with __agg_has_partner().

Delete null_mac_addr, which is not required anymore in bond_3ad.c, since
all references to it are gone.

Signed-off-by: Jones Syue <jonessyue@qnap.com>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
Link: https://lore.kernel.org/r/SI2PR04MB5097BCA8FF2A2F03D9A5A3EEDC5A2@SI2PR04MB5097.apcprd04.prod.outlook.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/bonding/bond_3ad.c