projects / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: bc6b827) | patch
NFC: st21nfca: ERR_PTR vs NULL fix
authorChristophe Ricard <christophe.ricard@gmail.com>
Sat, 13 Sep 2014 08:28:52 +0000 (10:28 +0200)
committerSamuel Ortiz <sameo@linux.intel.com>
Wed, 24 Sep 2014 00:02:24 +0000 (02:02 +0200)
commit459e794b9b1e0c6be93745344c40364296e7aacd
treeadff2ec56743a7bfd55d153791449396f38a1f62tree | snapshot
parentbc6b8275924b8af3d10ac35df0579d94fa169680commit | diff
NFC: st21nfca: ERR_PTR vs NULL fix

"skb" can be NULL here but it can't be an ERR_PTR:
- IS_ERR(NULL) return false and skb migth be NULL.
- skb cannot be a ERR_PTR as nfc_hci_send_cmd_async it never using such cast.

!skb is more appropriate at those places.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/nfc/st21nfca/st21nfca_dep.c diff | blob | history
ep93xx device tree rework repo: git://git.maquefel.me/linux.git