efi: efibc: check for efivars write capability
authorArd Biesheuvel <ardb@kernel.org>
Tue, 15 Sep 2020 15:12:09 +0000 (18:12 +0300)
committerArd Biesheuvel <ardb@kernel.org>
Tue, 15 Sep 2020 15:22:47 +0000 (18:22 +0300)
commit46908326c6b801201f1e46f5ed0db6e85bef74ae
tree188c86a4a9813c587dcc28c75f829def4fe2004c
parentfb1201aececc59990b75ef59fca93ae4aa1e1444
efi: efibc: check for efivars write capability

Branden reports that commit

  f88814cc2578c1 ("efi/efivars: Expose RT service availability via efivars abstraction")

regresses UEFI platforms that implement GetVariable but not SetVariable
when booting kernels that have EFIBC (bootloader control) enabled.

The reason is that EFIBC is a user of the efivars abstraction, which was
updated to permit users that rely only on the read capability, but not on
the write capability. EFIBC is in the latter category, so it has to check
explicitly whether efivars supports writes.

Fixes: f88814cc2578c1 ("efi/efivars: Expose RT service availability via efivars abstraction")
Tested-by: Branden Sherrell <sherrellbc@gmail.com>
Link: https://lore.kernel.org/linux-efi/AE217103-C96F-4AFC-8417-83EC11962004@gmail.com/
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
drivers/firmware/efi/efibc.c