scsi: libsas: Fix use-after-free bug in smp_execute_task_sg()
authorDuoming Zhou <duoming@zju.edu.cn>
Tue, 20 Sep 2022 14:42:13 +0000 (22:42 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 25 Sep 2022 16:56:07 +0000 (12:56 -0400)
commit46ba53c30666717cb06c2b3c5d896301cd00d0c0
treecd87a9f749bfef98f4fae299721abc6376a523ba
parentd88a0240ff76062eb0728963e7aacf6dbe87f7c7
scsi: libsas: Fix use-after-free bug in smp_execute_task_sg()

When executing SMP task failed, the smp_execute_task_sg() calls del_timer()
to delete "slow_task->timer". However, if the timer handler
sas_task_internal_timedout() is running, the del_timer() in
smp_execute_task_sg() will not stop it and a UAF will happen. The process
is shown below:

      (thread 1)               |        (thread 2)
smp_execute_task_sg()          | sas_task_internal_timedout()
 ...                           |
 del_timer()                   |
 ...                           |  ...
 sas_free_task(task)           |
  kfree(task->slow_task) //FREE|
                               |  task->slow_task->... //USE

Fix by calling del_timer_sync() in smp_execute_task_sg(), which makes sure
the timer handler have finished before the "task->slow_task" is
deallocated.

Link: https://lore.kernel.org/r/20220920144213.10536-1-duoming@zju.edu.cn
Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver")
Reviewed-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/libsas/sas_expander.c