Revert "Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT"
authorJohan Hovold <johan+linaro@kernel.org>
Thu, 14 Mar 2024 08:44:12 +0000 (09:44 +0100)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fri, 29 Mar 2024 13:48:37 +0000 (09:48 -0400)
commit4790a73ace86f3d165bbedba898e0758e6e1b82d
treef4490bbfd1f8097ef3d3ad9a3e2cf2a90e45c51e
parent0ba80d96585662299d4ea4624043759ce9015421
Revert "Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT"

This reverts commit 7dcd3e014aa7faeeaf4047190b22d8a19a0db696.

Qualcomm Bluetooth controllers like WCN6855 do not have persistent
storage for the Bluetooth address and must therefore start as
unconfigured to allow the user to set a valid address unless one has
been provided by the boot firmware in the devicetree.

A recent change snuck into v6.8-rc7 and incorrectly started marking the
default (non-unique) address as valid. This specifically also breaks the
Bluetooth setup for some user of the Lenovo ThinkPad X13s.

Note that this is the second time Qualcomm breaks the driver this way
and that this was fixed last year by commit 6945795bc81a ("Bluetooth:
fix use-bdaddr-property quirk"), which also has some further details.

Fixes: 7dcd3e014aa7 ("Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT")
Cc: stable@vger.kernel.org # 6.8
Cc: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reported-by: Clayton Craft <clayton@craftyguy.net>
Tested-by: Clayton Craft <clayton@craftyguy.net>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
drivers/bluetooth/hci_qca.c