wifi: ath12k: mhi: fix potential memory leak in ath12k_mhi_register()
authorMa Ke <make_ruc2021@163.com>
Sat, 30 Sep 2023 04:54:47 +0000 (07:54 +0300)
committerKalle Valo <quic_kvalo@quicinc.com>
Mon, 2 Oct 2023 16:02:34 +0000 (19:02 +0300)
commit47c27aa7ded4b8ead19b3487cc42a6185b762903
tree8a6b468ebb09fc1b2e3f05a65212d0f7bc810d57
parentaa75cc029e053627743fba2cde8a73519abe8421
wifi: ath12k: mhi: fix potential memory leak in ath12k_mhi_register()

mhi_alloc_controller() allocates a memory space for mhi_ctrl. When some
errors occur, mhi_ctrl should be freed by mhi_free_controller() and set
ab_pci->mhi_ctrl = NULL.

We can fix it by calling mhi_free_controller() when the failure happens
and set ab_pci->mhi_ctrl = NULL in all of the places where we call
mhi_free_controller().

Signed-off-by: Ma Ke <make_ruc2021@163.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230922021036.3604157-1-make_ruc2021@163.com
drivers/net/wireless/ath/ath12k/mhi.c