i2c: Remove redundant comparison in npcm_i2c_reg_slave
authorRand Deeb <rand.sec96@gmail.com>
Tue, 6 Feb 2024 19:42:01 +0000 (22:42 +0300)
committerAndi Shyti <andi.shyti@kernel.org>
Wed, 14 Feb 2024 21:51:54 +0000 (22:51 +0100)
commit48acf8292280f257fb0047478153a81471ee7f4d
tree9113e63d5361fcc8651fa9b8e1d8f2554444efe9
parent857cc04cdf508d043a062fff3aea8ca01303b731
i2c: Remove redundant comparison in npcm_i2c_reg_slave

In the npcm_i2c_reg_slave() function, there was a redundant
comparison that checked if 'bus->slave' was null immediately after
assigning it the 'client' value. There were concerns about a
potential null dereference because of `client->adapter`, but
according to Wolfram Sang, "we trusted ourselves here" Therefore,
this comparison is unnecessary.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Rand Deeb <rand.sec96@gmail.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-npcm7xx.c