PCI: vmd: Fix potential deadlock when enabling ASPM
authorJohan Hovold <johan+linaro@kernel.org>
Tue, 28 Nov 2023 08:15:08 +0000 (09:15 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 11 Dec 2023 18:07:59 +0000 (12:07 -0600)
commit49de0dc87965079a8e2803ee4b39f9d946259423
treee98ddb337f14976156eba96d36063965a5da6d32
parent718ab8226636a1a3a7d281f5d6a7ad7c925efe5a
PCI: vmd: Fix potential deadlock when enabling ASPM

The vmd_pm_enable_quirk() helper is called from pci_walk_bus() during
probe to enable ASPM for controllers with VMD_FEAT_BIOS_PM_QUIRK set.

Since pci_walk_bus() already holds a pci_bus_sem read lock, use
pci_enable_link_state_locked() to enable link states in order to avoid a
potential deadlock (e.g. in case someone takes a write lock before
reacquiring the read lock).

Fixes: f492edb40b54 ("PCI: vmd: Add quirk to configure PCIe ASPM and LTR")
Link: https://lore.kernel.org/r/20231128081512.19387-3-johan+linaro@kernel.org
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
[bhelgaas: add "potential" in subject since the deadlock has only been
reported by lockdep, include helper name in commit log]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: <stable@vger.kernel.org> # 6.3
Cc: Michael Bottini <michael.a.bottini@linux.intel.com>
Cc: David E. Box <david.e.box@linux.intel.com>
drivers/pci/controller/vmd.c