hw/i386/pc: Remove vmport value assertion
authorKamil Szczęk <kamil@szczek.dev>
Tue, 20 Aug 2024 23:11:24 +0000 (23:11 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 19 Nov 2024 16:36:28 +0000 (17:36 +0100)
commit4a7a119b91eedd16f52001b50df0fd5c223ada08
tree4f8a107f6d8381c28f93f82e0228335b8e36c6c8
parente6459afb1ff4d86b361b14f4a2fc43f0d2b4d679
hw/i386/pc: Remove vmport value assertion

There is no need for this assertion here, as we only use vmport value
for equality/inequality checks. This was originally prompted by the
following Coverity report:
 >>> CID 1559533:  Integer handling issues (CONSTANT_EXPRESSION_RESULT)
 >>> "pcms->vmport >= 0" is always true regardless of the values of
 >>> its operands. This occurs as the logical first operand of "&&".

Signed-off-by: Kamil Szczęk <kamil@szczek.dev>
Reported-By: Philippe Mathieu-Daudé <philmd@linaro.org>
Link: https://lore.kernel.org/r/ZwF9ZexNs1h-uC0MrbkgGtMtdyLinROjVSmMNVzNftjGVWgOiuzdD1dSXEtzNH7OHbBFY6GVDYVFIDBgc3lhGqCOb7kaNZolSBkVyl3rNr4=@szczek.dev
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/i386/pc.c