e1000e: fix link state on resume
authorLaurent Vivier <lvivier@redhat.com>
Wed, 24 Jan 2024 10:40:06 +0000 (11:40 +0100)
committerJason Wang <jasowang@redhat.com>
Tue, 12 Mar 2024 11:28:32 +0000 (19:28 +0800)
commit4cadf10234989861398e19f3bb441d3861f3bb7c
treeb38022da1710655fbe971ed9197cc8d49b6e2cf7
parent65c2ab808571dcd9322020690a63df63281a67f0
e1000e: fix link state on resume

On resume e1000e_vm_state_change() always calls e1000e_autoneg_resume()
that sets link_down to false, and thus activates the link even
if we have disabled it.

The problem can be reproduced starting qemu in paused state (-S) and
then set the link to down. When we resume the machine the link appears
to be up.

Reproducer:

   # qemu-system-x86_64 ... -device e1000e,netdev=netdev0,id=net0 -S

   {"execute": "qmp_capabilities" }
   {"execute": "set_link", "arguments": {"name": "net0", "up": false}}
   {"execute": "cont" }

To fix the problem, merge the content of e1000e_vm_state_change()
into e1000e_core_post_load() as e1000 does.

Buglink: https://issues.redhat.com/browse/RHEL-21867
Fixes: 6f3fbe4ed06a ("net: Introduce e1000e device emulation")
Suggested-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
hw/net/e1000e_core.c
hw/net/e1000e_core.h