drivers/base/memory: Fix an unlikely reference counting issue in __add_memory_block()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 22 Apr 2022 08:13:48 +0000 (10:13 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 22 Apr 2022 15:19:39 +0000 (17:19 +0200)
commit4e224719f5d9b92abf1e0edfb2a83053208f3026
tree512b84d64968dacd757053f5118c942cc27ca4ca
parent3677563eb8731e1ad5970e3e57f74e5f9d63502a
drivers/base/memory: Fix an unlikely reference counting issue in __add_memory_block()

__add_memory_block() calls both put_device() and device_unregister() when
storing the memory block into the xarray. This is incorrect because xarray
doesn't take an additional reference and device_unregister() already calls
put_device().

Triggering the issue looks really unlikely and its only effect should be to
log a spurious warning about a ref counted issue.

Fixes: 4fb6eabf1037 ("drivers/base/memory.c: cache memory blocks in xarray to accelerate lookup")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Link: https://lore.kernel.org/r/d44c63d78affe844f020dc02ad6af29abc448fc4.1650611702.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/memory.c