staging: vchiq_arm: Drop unnecessary NULL check
authorStefan Wahren <wahrenst@gmx.net>
Thu, 25 Apr 2024 16:58:48 +0000 (18:58 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 4 May 2024 16:42:01 +0000 (18:42 +0200)
commit4e81120fe11e2e7f76a9e557f3ca9ab5acb78040
tree9fed36830e1a05af61bac301e9e20811b3cfc96c
parenta0e244ec59bdc4caac4b7a105f029fd1af28f0f2
staging: vchiq_arm: Drop unnecessary NULL check

Looking at the handling of service instance within the VCHIQ
driver shows that it's not possible that service_callback is
called with instance is a NULL pointer. So drop the unnecessary
NULL check and fix:

vchiq_arm.c:1109 service_callback() warn:
  variable dereferenced before check 'instance' (see line 1091)

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/linux-arm-kernel/202404230315.vx7ESZ3r-lkp@intel.com/
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20240425165852.6681-2-wahrenst@gmx.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c