]> git.maquefel.me Git - brevno-suite/hugo/commit
Only invoke a given cached partial once
authorBjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>
Tue, 24 Jan 2023 19:57:15 +0000 (20:57 +0100)
committerBjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>
Wed, 25 Jan 2023 16:35:23 +0000 (17:35 +0100)
commit4ef9baf5bd24b6a105f78eba1147dad9ffabd82a
tree70b6de66d2baf3ccda53a05d488ac05964534760
parent93ed6e447a24f8d08f136bd35fe3117bd6b29396
Only invoke a given cached partial once

Note that this is backed by a LRU cache (which we soon shall see more usage of), so if you're a heavy user of cached partials it may be evicted and
refreshed if needed. But in most cases every partial is only invoked once.

This commit also adds a timeout (the global `timeout` config option) to make infinite recursion in partials
easier to reason about.

```
name              old time/op    new time/op    delta
IncludeCached-10    8.92ms ± 0%    8.48ms ± 1%   -4.87%  (p=0.016 n=4+5)

name              old alloc/op   new alloc/op   delta
IncludeCached-10    6.65MB ± 0%    5.17MB ± 0%  -22.32%  (p=0.002 n=6+6)

name              old allocs/op  new allocs/op  delta
IncludeCached-10      117k ± 0%       71k ± 0%  -39.44%  (p=0.002 n=6+6)
```

Closes #4086
Updates #9588
21 files changed:
deps/deps.go
go.mod
go.sum
helpers/general.go
helpers/general_test.go
hugolib/page_test.go
hugolib/resource_chain_test.go
hugolib/site.go
identity/identity.go
identity/identityhash.go [new file with mode: 0644]
identity/identityhash_test.go [new file with mode: 0644]
metrics/metrics.go
resources/image.go
resources/images/config.go
resources/images/filters_test.go
resources/internal/key.go
resources/page/site.go
resources/resource_factories/create/remote.go
tpl/partials/integration_test.go
tpl/partials/partials.go
tpl/partials/partials_test.go [deleted file]