iwlwifi: fix TLV fragment allocation loop
authorLuca Coelho <luciano.coelho@intel.com>
Mon, 25 Nov 2019 09:50:58 +0000 (11:50 +0200)
committerLuca Coelho <luciano.coelho@intel.com>
Mon, 23 Dec 2019 09:33:04 +0000 (11:33 +0200)
commit4f565ee2999960d541854389e20b78e7105e3afc
tree2cd93a1c7c942e3239c4afab972efa04bd9de58f
parenta89c72ffd07369f5ccc74f0332d2785a7077241d
iwlwifi: fix TLV fragment allocation loop

In the allocation loop, "pages" will never become zero (because of the
DIV_ROUND_UP), so if we can't allocate any size and pages becomes 1,
we will keep trying to allocate 1 page until it succeeds.  And in that
case, as coverity reported, block will never be NULL.

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487402 ("Control flow issues")
Fixes: 14124b25780d ("iwlwifi: dbg_ini: implement monitor allocation flow")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Fixes: 14124b25780d ("iwlwifi: dbg_ini: implement monitor allocation flow")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c