dmaengine: pxa_dma: Prefer struct_size over open coded arithmetic
authorLen Baker <len.baker@gmx.com>
Sat, 18 Sep 2021 10:40:55 +0000 (12:40 +0200)
committerGustavo A. R. Silva <gustavoars@kernel.org>
Wed, 20 Oct 2021 23:35:22 +0000 (18:35 -0500)
commit50740d5de6145cb88e69ccb29c586f10c401e3ee
tree78c3d1f42615fc31cfd75a3f98ac8a12cd1fd347
parent5dfbbb668af9038dfa9f280ff5835dfb9c796864
dmaengine: pxa_dma: Prefer struct_size over open coded arithmetic

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the struct_size() helper to do the arithmetic instead of the
argument "size + count * size" in the kzalloc() function.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Signed-off-by: Len Baker <len.baker@gmx.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
drivers/dma/pxa_dma.c