configure: remove --with-git= option
authorPaolo Bonzini <pbonzini@redhat.com>
Thu, 25 May 2023 10:36:28 +0000 (12:36 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 6 Jun 2023 14:30:01 +0000 (16:30 +0200)
commit50cfed80ecc01ea4300ed4b0ea5b567f381b9421
tree1715b487efdf206b34131df59a7dae45325b2404
parent47a90a51a9c24ba10c58c0cd09d2117cf9e3fde2
configure: remove --with-git= option

The scenario for which --with-git= was introduced was to use a SOCKS proxy
such as tsocks.  However, this was back in 2017 when QEMU's submodules
used the git:// protocol, and it is not as important when using the
"smart HTTP" backend; for example, neither "meson subprojects download"
nor scripts/checkpatch.pl obey the GIT environment variable.

So remove the knob, but test for the presence of git in the configure and
git-submodule.sh scripts, and suggest using --with-git-submodules=validate
+ a manual invocation of git-submodule.sh when git does not work.  Hopefully
in the future the GIT environment variable will be supported by Meson.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Makefile
configure
meson.build
scripts/ci/org.centos/stream/8/x86_64/configure
scripts/git-submodule.sh