x86/PAT: Use try_cmpxchg() in set_page_memtype()
authorUros Bizjak <ubizjak@gmail.com>
Mon, 16 Jan 2023 16:34:46 +0000 (17:34 +0100)
committerIngo Molnar <mingo@kernel.org>
Thu, 26 Jan 2023 10:49:39 +0000 (11:49 +0100)
commit50fd4d5e6914b60ea6f89c2cbff7a07799414c62
tree1b0fb8d3451fa4917a7b64207f0b1527eb4a8572
parent1d61659ced6bd8881cf2fb5cbcb28f9541fc7430
x86/PAT: Use try_cmpxchg() in set_page_memtype()

Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in
set_page_memtype.  x86 CMPXCHG instruction returns success in ZF flag,
so this change saves a compare after cmpxchg (and related move
instruction in front of cmpxchg).

Also, try_cmpxchg implicitly assigns old *ptr value to "old" when cmpxchg
fails. There is no need to re-read the value in the loop.

Note that the value from *ptr should be read using READ_ONCE to prevent
the compiler from merging, refetching or reordering the read.

No functional change intended.

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20230116163446.4734-1-ubizjak@gmail.com
arch/x86/mm/pat/memtype.c