virtio-net: set queues after driver_ok
authorJason Wang <jasowang@redhat.com>
Thu, 10 Aug 2023 03:12:56 +0000 (23:12 -0400)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 Aug 2023 08:50:14 +0000 (09:50 +0100)
commit51b813176f098ff61bd2833f627f5319ead098a5
tree6295646e95ce075a1e36d47dee91ee9c9e19f1dc
parent9ebbb29db9cae23e29881b9a268767d4baa53cdb
virtio-net: set queues after driver_ok

Commit 25266128fe16 ("virtio-net: fix race between set queues and
probe") tries to fix the race between set queues and probe by calling
_virtnet_set_queues() before DRIVER_OK is set. This violates virtio
spec. Fixing this by setting queues after virtio_device_ready().

Note that rtnl needs to be held for userspace requests to change the
number of queues. So we are serialized in this way.

Fixes: 25266128fe16 ("virtio-net: fix race between set queues and probe")
Reported-by: Dragos Tatulea <dtatulea@nvidia.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/virtio_net.c