net: qrtr: fix memory leaks
authorPavel Skripkin <paskripkin@gmail.com>
Fri, 23 Jul 2021 15:31:32 +0000 (18:31 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Jul 2021 16:48:06 +0000 (17:48 +0100)
commit52f3456a96c06760b9bfae460e39596fec7af22e
treeecd9696e9a744d91aa86d0ebadeb2d4b3c4c9637
parent200bd5668c04d35510d152aa2f74c659f705a5b3
net: qrtr: fix memory leaks

Syzbot reported memory leak in qrtr. The problem was in unputted
struct sock. qrtr_local_enqueue() function calls qrtr_port_lookup()
which takes sock reference if port was found. Then there is the following
check:

if (!ipc || &ipc->sk == skb->sk) {
...
return -ENODEV;
}

Since we should drop the reference before returning from this function and
ipc can be non-NULL inside this if, we should add qrtr_port_put() inside
this if.

The similar corner case is in qrtr_endpoint_post() as Manivannan
reported. In case of sock_queue_rcv_skb() failure we need to put
port reference to avoid leaking struct sock pointer.

Fixes: e04df98adf7d ("net: qrtr: Remove receive worker")
Fixes: bdabad3e363d ("net: Add Qualcomm IPC router")
Reported-and-tested-by: syzbot+35a511c72ea7356cdcf3@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/qrtr/qrtr.c