xfs: remove xfs_da_args.attr_flags
authorDarrick J. Wong <djwong@kernel.org>
Mon, 22 Apr 2024 16:47:21 +0000 (09:47 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Tue, 23 Apr 2024 14:46:50 +0000 (07:46 -0700)
commit54275d8496f3e4764302cebc0e9517d950ba6589
treeddea806b9910875a1b3357788a1398d2adf2c7cf
parent779a4b606c7678343e3603398fe07de38b817ef4
xfs: remove xfs_da_args.attr_flags

This field only ever contains XATTR_{CREATE,REPLACE}, and it only goes
as deep as xfs_attr_set.  Remove the field from the structure and
replace it with an enum specifying exactly what kind of change we want
to make to the xattr structure.  Upsert is the name that we'll give to
the flags==0 operation, because we're either updating an existing value
or inserting it, and the caller doesn't care.

Note: The "UPSERTR" name created here is to make userspace porting
easier.  It will be removed in the next patch.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/xfs/libxfs/xfs_attr.c
fs/xfs/libxfs/xfs_attr.h
fs/xfs/libxfs/xfs_da_btree.h
fs/xfs/scrub/attr_repair.c
fs/xfs/xfs_acl.c
fs/xfs/xfs_ioctl.c
fs/xfs/xfs_iops.c
fs/xfs/xfs_trace.h
fs/xfs/xfs_xattr.c
fs/xfs/xfs_xattr.h