drivers/fpga: use standard array-copy function
authorPhilipp Stanner <pstanner@redhat.com>
Tue, 14 Nov 2023 11:19:02 +0000 (12:19 +0100)
committerXu Yilun <yilun.xu@linux.intel.com>
Fri, 17 Nov 2023 08:34:26 +0000 (16:34 +0800)
commit5496fb8eedd637e1e9d87655f86dc816afd5ad68
tree7d7fe0b1aeaccd5f7e0e0130366e520e92ef3abc
parentb85ea95d086471afb4ad062012a4d73cd328fa86
drivers/fpga: use standard array-copy function

dfl.c utilizes memdup_user() and array_size() to copy a userspace array.
array_size() will likely never trigger thanks to the preceding check.
Nevertheless, in the theoretical event that it would, it would return
SIZE_MAX to memdup_user(), resulting in an attempt to allocate huge
amounts of memory.

string.h from the core-api now provides memdup_array_user() which also
performs an overflow check and returns an error-pointer with -EOVERFLOW
to the caller.
As an additional advantage it standardizes how userspace-arrays are
being copied and, thus, makes it more obvious to readers that an array
is being copied.

Replace memdup_user() with memdup_array_user().

Suggested-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20231114111901.19380-2-pstanner@redhat.com
Signed-off-by: Xu Yilun <yilun.xu@linux.intel.com>
drivers/fpga/dfl.c