net: drop bogus skb with CHECKSUM_PARTIAL and offset beyond end of trimmed packet
authorVasily Averin <vvs@virtuozzo.com>
Mon, 14 Dec 2020 19:07:39 +0000 (22:07 +0300)
committerJakub Kicinski <kuba@kernel.org>
Tue, 15 Dec 2020 02:41:01 +0000 (18:41 -0800)
commit54970a2fbb673f090b7f02d7f57b10b2e0707155
tree11b28387872b78f796c1f7402261cd4fd960f963
parent0780b4145634c3e8d69905dc5d2695d1207130df
net: drop bogus skb with CHECKSUM_PARTIAL and offset beyond end of trimmed packet

syzbot reproduces BUG_ON in skb_checksum_help():
tun creates (bogus) skb with huge partial-checksummed area and
small ip packet inside. Then ip_rcv trims the skb based on size
of internal ip packet, after that csum offset points beyond of
trimmed skb. Then checksum_tg() called via netfilter hook
triggers BUG_ON:

        offset = skb_checksum_start_offset(skb);
        BUG_ON(offset >= skb_headlen(skb));

To work around the problem this patch forces pskb_trim_rcsum_slow()
to return -EINVAL in described scenario. It allows its callers to
drop such kind of packets.

Link: https://syzkaller.appspot.com/bug?id=b419a5ca95062664fe1a60b764621eb4526e2cd0
Reported-by: syzbot+7010af67ced6105e5ab6@syzkaller.appspotmail.com
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/1b2494af-2c56-8ee2-7bc0-923fcad1cdf8@virtuozzo.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/skbuff.c