tipc: fix incorrect order of state message data sanity check
authorTung Nguyen <tung.q.nguyen@dektech.com.au>
Tue, 8 Mar 2022 02:11:59 +0000 (02:11 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Mar 2022 13:23:38 +0000 (14:23 +0100)
commit5548c81e97ab85fb03199d7080b8441957bdea3a
treef511ecf8bd523553ed17b12285cc4657192cec3c
parent5e7c402892e189a7bc152b125e72261154aa585d
tipc: fix incorrect order of state message data sanity check

[ Upstream commit c79fcc27be90b308b3fa90811aefafdd4078668c ]

When receiving a state message, function tipc_link_validate_msg()
is called to validate its header portion. Then, its data portion
is validated before it can be accessed correctly. However, current
data sanity  check is done after the message header is accessed to
update some link variables.

This commit fixes this issue by moving the data sanity check to
the beginning of state message handling and right after the header
sanity check.

Fixes: 9aa422ad3266 ("tipc: improve size validations for received domain records")
Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Tung Nguyen <tung.q.nguyen@dektech.com.au>
Link: https://lore.kernel.org/r/20220308021200.9245-1-tung.q.nguyen@dektech.com.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/tipc/link.c