media: rkisp1: capture: Fix and simplify (un)registration
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Thu, 24 Feb 2022 12:58:40 +0000 (12:58 +0000)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 27 Jun 2022 06:57:44 +0000 (07:57 +0100)
commit55fcb913d5d3d1f3d0ce91d8d42c50d9cd496427
tree2234e57627aa3b219ff6593a164d8dfcce64d281
parent56c8534e2d2f9bf789cdfc50e62bc30c992da69f
media: rkisp1: capture: Fix and simplify (un)registration

The rkisp1_register_capture() and rkisp1_unregister_capture() functions
don't destroy the mutex (in the error path for the former). Fix this and
make rkisp1_unregister_capture() and rkisp1_capture_devs_unregister()
safe to be called on an unregistered capture node to prepare for
simplification of error handling at probe time.

While at it, drop the double initialization of cap->rkisp1 in
rkisp1_capture_devs_register() as the field is already initialized in
rkisp1_capture_init().

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c