KVM: x86: Harden copying of userspace-array against overflow
authorPhilipp Stanner <pstanner@redhat.com>
Thu, 2 Nov 2023 18:15:24 +0000 (19:15 +0100)
committerSean Christopherson <seanjc@google.com>
Thu, 30 Nov 2023 21:16:21 +0000 (13:16 -0800)
commit573cc0e5cf142d9992d2de3502800890fc717bc0
tree01147a1ba8e9cc0de2a5aeb0fdaac18e4fb17b92
parent63912245c19d3a4179da44beefd017eb9270f207
KVM: x86: Harden copying of userspace-array against overflow

cpuid.c utilizes vmemdup_user() and array_size() to copy two userspace
arrays. This, currently, does not check for an overflow.

Use the new wrapper vmemdup_array_user() to copy the arrays more safely,
as vmemdup_user() doesn't check for overflow.

Note, KVM explicitly checks the number of entries before duplicating the
array, i.e. adding the overflow check should be a glorified nop.

Suggested-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Link: https://lore.kernel.org/r/20231102181526.43279-2-pstanner@redhat.com
[sean: call out that KVM pre-checks the number of entries]
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/cpuid.c