efi/x86: Preserve %ebx correctly in efi_set_virtual_address_map()
authorArd Biesheuvel <ardb@kernel.org>
Sun, 8 Mar 2020 08:08:52 +0000 (09:08 +0100)
committerIngo Molnar <mingo@kernel.org>
Sun, 8 Mar 2020 08:58:23 +0000 (09:58 +0100)
commit57648adb317c6f05d80a813130f8b88cecf1facf
tree7524247dc648934cc3e98774ab933fc10de21d8f
parentdd09fad9d2caad2325a39b766ce9e79cfc690184
efi/x86: Preserve %ebx correctly in efi_set_virtual_address_map()

Commit:

  59f2a619a2db8611 ("efi: Add 'runtime' pointer to struct efi")

modified the assembler routine called by efi_set_virtual_address_map(),
to grab the 'runtime' EFI service pointer while running with paging
disabled (which is tricky to do in C code)

After the change, register %ebx is not restored correctly, resulting
in all kinds of weird behavior, so fix that.

Reported-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20200304133515.15035-1-ardb@kernel.org
Link: https://lore.kernel.org/r/20200308080859.21568-22-ardb@kernel.org
arch/x86/platform/efi/efi_stub_32.S