net: dsa: microchip: Fix uninitialized var in ksz9477_acl_move_entries()
authorOleksij Rempel <o.rempel@pengutronix.de>
Fri, 6 Oct 2023 11:58:22 +0000 (13:58 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 10 Oct 2023 09:12:01 +0000 (11:12 +0200)
commit59fe651753fb897ebe0ac91c19cf503e7a551632
tree3b70005a3038b8d30c29084d1d1c9be4378f4f87
parentc41a38ef3bf78a86f94c3f67a19368a98c10ee2c
net: dsa: microchip: Fix uninitialized var in ksz9477_acl_move_entries()

Address an issue in ksz9477_acl_move_entries() where, in the scenario
(src_idx == dst_idx), ksz9477_validate_and_get_src_count() returns 0,
leading to usage of uninitialized src_count and dst_count variables,
which causes undesired behavior as it attempts to move ACL entries
around.

Fixes: 002841be134e ("net: dsa: microchip: Add partial ACL support for ksz9477 switches")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Suggested-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20231006115822.144152-1-o.rempel@pengutronix.de
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/dsa/microchip/ksz9477_acl.c