hw/i386/vmmouse: Require 'i8042' property to be set
authorPhilippe Mathieu-Daudé <f4bug@amsat.org>
Wed, 1 Dec 2021 22:32:53 +0000 (23:32 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Sat, 18 Dec 2021 09:57:37 +0000 (10:57 +0100)
commit5a3a2eb3b1096a52580c1b8c3eb0739714e7d941
treec016a716941664aaca665161fd938ea6b3bd4550
parent08c34c642dbcb5f7d9d94b07b471f80e333541cc
hw/i386/vmmouse: Require 'i8042' property to be set

If the 'i8042' property is not set, mouse events handled by
vmmouse_mouse_event() end calling i8042_isa_mouse_fake_event()
with a NULL argument, resulting in ps2_mouse_fake_event() being
called with invalid PS2MouseState pointer. Fix by requiring
the 'i8042' property to be always set:

  $ qemu-system-x86_64 -device vmmouse
  qemu-system-x86_64: -device vmmouse: 'i8042' link is not set

Fixes: 91c9e09147b ("vmmouse: convert to qdev")
Reported-by: Calvin Buckley <calvin@cmpct.info>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/752
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20211201223253.36080-1-f4bug@amsat.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/i386/vmmouse.c