ip_tunnel: harden copying IP tunnel params to userspace
authorAlexander Lobakin <aleksander.lobakin@intel.com>
Thu, 4 Apr 2024 16:03:02 +0000 (18:03 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 Apr 2024 10:02:00 +0000 (11:02 +0100)
commit5a66cda52d7daccc88aa358872816c35093759f9
treeccba1c1a312900302f0f0220d21bfe072456b0e1
parenteec53cc38c4aba41bc3fabd0a75bc30c2c8ea332
ip_tunnel: harden copying IP tunnel params to userspace

Structures which are about to be copied to userspace shouldn't have
uninitialized fields or paddings.
memset() the whole &ip_tunnel_parm in ip_tunnel_parm_to_user() before
filling it with the kernel data. The compilers will hopefully combine
writes to it.

Fixes: 117aef12a7b1 ("ip_tunnel: use a separate struct to store tunnel params in the kernel")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/netdev/5f63dd25-de94-4ca3-84e6-14095953db13@moroto.mountain
Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_tunnel.c