pinctrl: sprd: Add of_node_put() before return to prevent memory leak
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Thu, 8 Aug 2019 07:43:29 +0000 (13:13 +0530)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 10 Aug 2019 08:22:50 +0000 (10:22 +0200)
commit5a6bc29032700bcc1fb752dd58f73179a78d115b
tree8fcc3448b065ae15ff26ba942dae4dcc1f8ddd8e
parent474137c9111a533aeaa46c1630bb9fb106a46e30
pinctrl: sprd: Add of_node_put() before return to prevent memory leak

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return in
two places.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190808074329.15579-1-nishkadg.linux@gmail.com
Reviewed-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/sprd/pinctrl-sprd.c