pcie: introduce pcie_sltctl_powered_off() helper
authorVladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Thu, 16 Feb 2023 18:03:49 +0000 (21:03 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 2 Mar 2023 08:10:49 +0000 (03:10 -0500)
commit5aaed9caf150390bd702a7da86a287a579b20d73
tree72242bbca3058cd8fe7ff3ef36fbe88ecd7ef709
parentf90d932094c03cb2ebb856a6da4ad0a5b05d9c27
pcie: introduce pcie_sltctl_powered_off() helper

In pcie_cap_slot_write_config() we check for PCI_EXP_SLTCTL_PWR_OFF in
a bad form. We should distinguish PCI_EXP_SLTCTL_PWR which is a "mask"
and PCI_EXP_SLTCTL_PWR_OFF which is value for that mask.

Better code is in pcie_cap_slot_unplug_request_cb() and in
pcie_cap_update_power(). Let's use same pattern everywhere. To simplify
things add also a helper.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Anton Kuchin <antonkuchin@yandex-team.ru>
Message-Id: <20230216180356.156832-12-vsementsov@yandex-team.ru>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/pci/pcie.c