wifi: hostap: Add __counted_by for struct prism2_download_data and use struct_size()
authorGustavo A. R. Silva <gustavoars@kernel.org>
Mon, 9 Oct 2023 19:41:18 +0000 (13:41 -0600)
committerKalle Valo <kvalo@kernel.org>
Wed, 11 Oct 2023 09:20:12 +0000 (12:20 +0300)
commit5cf47dc14158f979ee9485fc15e004c0d6952ea7
tree56903da90aa56db7712eeef0d19e467fa616050f
parentde8dd096949820ce5656d41ce409a67603e79327
wifi: hostap: Add __counted_by for struct prism2_download_data and use struct_size()

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

While there, use struct_size() helper, instead of the open-coded
version, to calculate the size for the allocation of the whole
flexible structure, including of course, the flexible-array member.

This code was found with the help of Coccinelle, and audited and
fixed manually.

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/ZSRXXvWMMkm7qqRW@work
drivers/net/wireless/intersil/hostap/hostap_download.c
drivers/net/wireless/intersil/hostap/hostap_wlan.h