backends/hostmem: Report error when memory size is unaligned
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 5 Jun 2024 10:44:58 +0000 (12:44 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Sat, 8 Jun 2024 08:33:38 +0000 (10:33 +0200)
commit5d9a9a617053a97a76ef332896c386d8fc895631
treedf6cf71038ce21301f4e579c836e860ac5940881
parent210b7b2b3cdef01a15ebabf02dd1a9d8a51743ba
backends/hostmem: Report error when memory size is unaligned

If memory-backend-{file,ram} has a size that's not aligned to
underlying page size it is not only wasteful, but also may lead
to hard to debug behaviour. For instance, in case
memory-backend-file and hugepages, madvise() and mbind() fail.
Rightfully so, page is the smallest unit they can work with. And
even though an error is reported, the root cause it not very
clear:

  qemu-system-x86_64: Couldn't set property 'dump' on 'memory-backend-file': Invalid argument

After this commit:

  qemu-system-x86_64: backend 'memory-backend-file' memory size must be multiple of 2 MiB

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Mario Casquero <mcasquer@redhat.com>
Message-ID: <b5b9f9c6bba07879fb43f3c6f496c69867ae3716.1717584048.git.mprivozn@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
backends/hostmem-epc.c
backends/hostmem-file.c
backends/hostmem-memfd.c
backends/hostmem.c
include/sysemu/hostmem.h