aoe: replace strncpy with strscpy
authorJustin Stitt <justinstitt@google.com>
Tue, 19 Sep 2023 05:27:45 +0000 (05:27 +0000)
committerJens Axboe <axboe@kernel.dk>
Wed, 4 Oct 2023 00:23:48 +0000 (18:23 -0600)
commit5e9b7cfc209b84d135993b8cb75ea383f24b2bba
tree43897e70d05643c4ff0b88acf87ff8074e0bc032
parente1f2760ba3478fa3f8c48db8e91fbe3df8bea2f8
aoe: replace strncpy with strscpy

`strncpy` is deprecated for use on NUL-terminated destination strings [1].

`aoe_iflist` is expected to be NUL-terminated which is evident by its
use with string apis later on like `strspn`:
|  p = aoe_iflist + strspn(aoe_iflist, WHITESPACE);

It also seems `aoe_iflist` does not need to be NUL-padded which means
`strscpy` [2] is a suitable replacement due to the fact that it
guarantees NUL-termination on the destination buffer while not
unnecessarily NUL-padding.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>
Cc: Xu Panda <xu.panda@zte.com.cn>
Cc: Yang Yang <yang.yang29@zte.com>
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230919-strncpy-drivers-block-aoe-aoenet-c-v2-1-3d5d158410e9@google.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/aoe/aoenet.c