MIPS: cpu-probe: ingenic: Fix broken BUG_ON
authorPaul Cercueil <paul@crapouillou.net>
Sun, 6 Sep 2020 19:29:24 +0000 (21:29 +0200)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Fri, 18 Sep 2020 14:27:32 +0000 (16:27 +0200)
commit5f5ed0ebcf84c7479c93a28c5c0e1b0b6926883b
tree879402e638c52de12adb0fb2a18b3b63ba5df04b
parent5ef415107dfd42a334d62a9b7be9754817df92ed
MIPS: cpu-probe: ingenic: Fix broken BUG_ON

The previous code was doing:
BUG_ON(!__builtin_constant_p(cpu_has_counter) || cpu_has_counter);

This only worked as the "cpu_has_counter" macro was overridden in
<cpu-feature-overrides.h>. The default "cpu_has_counter" macro is
non-constant, which triggered the BUG_ON() independently of the value
returned by the macro.

What we want to check here, is that *if* the macro was overridden to a
compile-time constant, then must be defined to zero, otherwise it's a
bug.

So the correct check is:
BUG_ON(__builtin_constant_p(cpu_has_counter) && cpu_has_counter);

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/kernel/cpu-probe.c