migration: remove unreachable code after reading data
authorDaniel P. Berrangé <berrange@redhat.com>
Mon, 27 Jun 2022 13:53:18 +0000 (14:53 +0100)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Wed, 20 Jul 2022 11:15:09 +0000 (12:15 +0100)
commit5f87072e9532a92e6270577665aa2fa659ec0b3f
tree291a50392575206dcd762161751d401b3827883d
parent8f6fe91512cdc187e51108a4e57d7af6ccadd6d8
migration: remove unreachable code after reading data

The code calls qio_channel_read() in a loop when it reports
QIO_CHANNEL_ERR_BLOCK. This code is reported when errno==EAGAIN.

As such the later block of code will always hit the 'errno != EAGAIN'
condition, making the final 'else' unreachable.

Fixes: Coverity CID 1490203
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220627135318.156121-1-berrange@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
migration/qemu-file.c