hwmon: (nzxt-kraken3) Bail out for unsupported device variants
authorGuenter Roeck <linux@roeck-us.net>
Sun, 12 May 2024 16:07:01 +0000 (09:07 -0700)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 12 May 2024 23:50:11 +0000 (16:50 -0700)
commit5fbf8734fb36cf67339f599f0e51747a6aff690c
tree7cc97cc4f286c3af59d4265e2437bd913a37742c
parentc82337843dd7c0723e7ce2b86e5ed89d71f1c7c3
hwmon: (nzxt-kraken3) Bail out for unsupported device variants

Dan Carpenter reports:

Commit cbeb479ff4cd ("hwmon: (nzxt-kraken3) Decouple device names
from kinds") from Apr 28, 2024 (linux-next), leads to the following
Smatch static checker warning:

drivers/hwmon/nzxt-kraken3.c:957 kraken3_probe()
error: uninitialized symbol 'device_name'.

Indeed, 'device_name' will be uninitizalized if an unknown product is
encountered. In practice this should not matter because the driver
should not instantiate on unknown products, but lets play safe and
bail out if that happens.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-hwmon/b1738c50-db42-40f0-a899-9c027c131ffb@moroto.mountain/
Cc: Jonas Malaco <jonas@protocubo.io>
Cc: Aleksa Savic <savicaleksa83@gmail.com>
Fixes: cbeb479ff4cd ("hwmon: (nzxt-kraken3) Decouple device names from kinds")
Acked-by: Jonas Malaco <jonas@protocubo.io>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/nzxt-kraken3.c